Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UTOPIA-1328] Removed delete comments btn in Complete status #1431

Merged
merged 2 commits into from
Aug 1, 2023
Merged

[UTOPIA-1328] Removed delete comments btn in Complete status #1431

merged 2 commits into from
Aug 1, 2023

Conversation

BradyMitch
Copy link
Contributor

Description

This PR includes the following proposed change(s):

UTOPIA-1208 Restrict Commenting on Completed PIAs

  • Removed ability to delete comments or access comment options if comments are disabled (from statusList).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Visually, comment options icon is gone in Completed status.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA Web App PR contains changes to DPIA frontend app label Jul 31, 2023
antsand
antsand approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@antsand antsand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!!

@github-actions
Copy link

github-actions bot commented Aug 1, 2023 

# npm audit report

@cypress/request  *
Severity: moderate
Server-Side Request Forgery in Request - https://github.com/advisories/GHSA-p8p7-x288-28g6
Depends on vulnerable versions of tough-cookie
fix available via `npm audit fix --force`
Will install cypress@4.2.0, which is a breaking change
node_modules/@cypress/request
  cypress  >=4.3.0
  Depends on vulnerable versions of @cypress/request
  node_modules/cypress

mockery  *
Severity: critical
mockery is vulnerable to prototype pollution - https://github.com/advisories/GHSA-gmwp-3pwc-3j3g
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/mockery
  @wdio/cucumber-framework  *
  Depends on vulnerable versions of @cucumber/cucumber
  Depends on vulnerable versions of mockery
  node_modules/@wdio/cucumber-framework
    wdio-cucumberjs-json-reporter  >=1.0.5
    Depends on vulnerable versions of @wdio/cucumber-framework
    node_modules/wdio-cucumberjs-json-reporter

semver  <=5.7.1 || 6.0.0 - 6.3.0 || 7.0.0 - 7.5.1
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix --force`
Will install wdio-cucumberjs-json-reporter@1.0.4, which is a breaking change
node_modules/@babel/core/node_modules/semver
node_modules/@babel/helper-compilation-targets/node_modules/semver
node_modules/@babel/helper-create-class-features-plugin/node_modules/semver
node_modules/@babel/helper-create-regexp-features-plugin/node_modules/semver
node_modules/@babel/helper-define-polyfill-provider/node_modules/semver
node_modules/@babel/preset-env/node_modules/semver
node_modules/@jest/core/node_modules/semver
node_modules/babel-plugin-istanbul/node_modules/semver
node_modules/babel-plugin-polyfill-corejs2/node_modules/semver
node_modules/cac/node_modules/semver
node_modules/eslint-config-airbnb-base/node_modules/semver
node_modules/eslint-plugin-jsx-a11y/node_modules/semver
node_modules/eslint-plugin-react/node_modules/semver
node_modules/istanbul-lib-report/node_modules/semver
node_modules/make-dir/node_modules/semver
node_modules/read-pkg-up/node_modules/semver
node_modules/semver
  @cucumber/cucumber  8.0.0-rc.1 - 9.2.0
  Depends on vulnerable versions of semver
  node_modules/@cucumber/cucumber

tough-cookie  <4.1.3
Severity: moderate
tough-cookie Prototype Pollution vulnerability - https://github.com/advisories/GHSA-72xf-g2v4-qvf3
fix available via `npm audit fix --force`
Will install cypress@4.2.0, which is a breaking change
node_modules/tough-cookie

word-wrap  <1.2.4
Severity: moderate
word-wrap vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-j8xg-fqg3-53r7
fix available via `npm audit fix`
node_modules/word-wrap

9 vulnerabilities (6 moderate, 3 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

@bcgov bcgov deleted a comment from github-actions bot Aug 1, 2023
@BradyMitch BradyMitch merged commit e004c3a into main Aug 1, 2023
5 of 6 checks passed
@BradyMitch BradyMitch deleted the UTOPIA-1328 branch August 1, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antsand antsand antsand approved these changes

@binggaofw binggaofw binggaofw approved these changes

@Bottle7 Bottle7 Awaiting requested review from Bottle7 Bottle7 is a code owner

@akroon3r akroon3r Awaiting requested review from akroon3r akroon3r is a code owner

@kushal-arora-fw kushal-arora-fw Awaiting requested review from kushal-arora-fw

@akhilfw akhilfw Awaiting requested review from akhilfw

@NoorChasib NoorChasib Awaiting requested review from NoorChasib NoorChasib is a code owner

@JieunSon96 JieunSon96 Awaiting requested review from JieunSon96 JieunSon96 is a code owner

Assignees

@BradyMitch BradyMitch

Labels
DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BradyMitch @antsand @binggaofw